openvibers/openvibe.work Commits

account-data: pin openvibe-sdk 0.74.0 and guard every table with a person column (#130)

OP OpenVibers committed 14 days ago · 22bca0140c · 5 files, +23 −10

Changes

ddiff --git a/README.md b/README.md
iindex 4bd1d65..fc7fc8b 100644
---- a/README.md
++++ b/README.md
@@@ -89,7 +89,7 @@ Its own PostgreSQL tables, created by [migrations/](migrations/) and written by
    (`WORK_ARBEITNOW_URL`, `WORK_REMOTIVE_URL`, `WORK_REMOTEOK_URL`, `WORK_USER_AGENT`).
  - **PostgreSQL** (`DATABASE_URL`, `DATABASE_DIRECT_URL`; an embedded PGlite database in development via
    `WORK_PGLITE_DIR`) and **Valkey** for shared limit counters (`VALKEY_URL`, `VALKEY_PREFIX`).
--- **Packages**: `openvibe-contracts` v0.222.0, `openvibe-sdk` v0.67.0 (`db`, `auth`, `account-data`, `limits`,
++- **Packages**: `openvibe-contracts` v0.222.0, `openvibe-sdk` v0.74.0 (`db`, `auth`, `account-data`, `limits`,
    `valkey`, `service`) and `openvibe-shared` v4.48.0 (`frame`, `legal`, `serve`, `release`, `metrics`, `ready`,
    `seo`, `shell`, `cache-policy`, `showcase`, `app-icon`).
  
@@@ -272,7 +272,7 @@ Part of the [OpenVibe network](https://openvibe.network). Built in the open by [
  
  <!-- versions:start -->
  - openvibe-contracts: v0.222.0
--- openvibe-sdk: v0.73.0
++- openvibe-sdk: v0.74.0
  - openvibe-shared: v4.48.0
  - openvibe-publishing: v1.4.0
  <!-- versions:end -->
ddiff --git a/STATUS.json b/STATUS.json
iindex 75863e0..01abca5 100644
---- a/STATUS.json
++++ b/STATUS.json
@@@ -8,11 +8,11 @@
    "port": "4960",
    "domain": "openvibe.work",
    "contracts": "openvibe-contracts v0.222.0",
--  "sdk": "openvibe-sdk v0.73.0",
++  "sdk": "openvibe-sdk v0.74.0",
    "shared": "openvibe-shared v4.48.0",
    "packages": [
      "openvibe-contracts v0.222.0",
--    "openvibe-sdk v0.73.0",
++    "openvibe-sdk v0.74.0",
      "openvibe-shared v4.48.0",
      "openvibe-publishing v1.4.0"
    ],
ddiff --git a/package-lock.json b/package-lock.json
iindex f5a50c5..44e0401 100644
---- a/package-lock.json
++++ b/package-lock.json
@@@ -17,7 +17,7 @@
          "iovalkey": "^0.4.0",
          "openvibe-contracts": "https://codeload.github.com/OpenVibers/OpenVibe.Contracts/tar.gz/refs/tags/v0.222.0",
          "openvibe-publishing": "https://codeload.github.com/OpenVibers/OpenVibe.Publishing/tar.gz/refs/tags/v1.4.0",
--        "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.73.0",
++        "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.74.0",
          "openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.48.0",
          "pg": "^8.23.0"
        },
@@@ -1181,9 +1181,9 @@
        }
      },
      "node_modules/openvibe-sdk": {
--      "version": "0.73.0",
--      "resolved": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.73.0",
--      "integrity": "sha512-XClxoVm9M6RA8eXlGgYZ0u6q9n5h79mCXqAAEg9fX21KgcqP69RmG+cX+6wrOf7TaEj7eSBWMxHjiIeIa9N7Dg==",
++      "version": "0.74.0",
++      "resolved": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.74.0",
++      "integrity": "sha512-DO9KVPnUriY/I4lX6ZEJtXaUvRDbJyqnqJxvlpl+zkNGFILpmuBXVJogNOCfK071Qci1gg7C4Iw1Xrseklcajg==",
        "license": "MIT",
        "bin": {
          "openvibe-download": "bin/openvibe-download.js"
ddiff --git a/package.json b/package.json
iindex 96f313e..3c09b5b 100644
---- a/package.json
++++ b/package.json
@@@ -25,7 +25,7 @@
      "iovalkey": "^0.4.0",
      "openvibe-contracts": "https://codeload.github.com/OpenVibers/OpenVibe.Contracts/tar.gz/refs/tags/v0.222.0",
      "openvibe-publishing": "https://codeload.github.com/OpenVibers/OpenVibe.Publishing/tar.gz/refs/tags/v1.4.0",
--    "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.73.0",
++    "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.74.0",
      "openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.48.0",
      "pg": "^8.23.0"
    },
ddiff --git a/test/account-data.test.js b/test/account-data.test.js
iindex 9429d8d..5632f01 100644
---- a/test/account-data.test.js
++++ b/test/account-data.test.js
@@@ -8,10 +8,12 @@
  const assert = require('assert');
  const http = require('http');
  const { boot, check, done } = require('./helpers/boot');
--const { createNetworkSender } = require('openvibe-sdk/account-data');
++const { createNetworkSender, uncovered } = require('openvibe-sdk/account-data');
  const { signDeliveryHeaders } = require('openvibe-sdk/events');
  const jobsStore = require('../server/jobs/store');
  const appsStore = require('../server/applications');
++const { TABLES } = require('../server/identity/account-data');
++const { testDb } = require('./helpers/db');
  
  const A = 'usr_01JZ0000000000000000000AAA';
  const B = 'usr_01JZ0000000000000000000BBB';
@@@ -64,6 +66,17 @@ async function makeApplication(t, subject) {
  }
  
  (async () => {
++    await check('every table that names a person is covered or exempted with a reason', async () => {
++        const d = await testDb();
++        try {
++            const missing = await uncovered(d.db, {
++                tables: TABLES,
++                               exempt: {"account_data_events":"the ledger of requests itself: which export and deletion work applied","work_index_revisions":"owner is the search-index document's owner (type/id), not a person; the row holds a revision and hash"},
++            });
++            assert.deepStrictEqual(missing, [], `a table with a person column is neither covered nor exempted: ${missing.join(', ')}`);
++        } finally { await d.close(); }
++    });
++
      await check('an export part carries only the person\'s saved searches, and no secret', async () => {
          const stub = await startNetworkStub();
          const sender = createNetworkSender({ networkInternalUrl: stub.url, clientId: 'work', clientSecret: 'work-secret' });