openvibers/openvibe.wiki Commits

account-data: pin openvibe-sdk 0.74.0 and guard every table with a person column (#156)

OP OpenVibers committed 14 days ago · 5cb6b2c405 · 5 files, +23 −10

* account-data: pin openvibe-sdk 0.74.0 and guard every table with a person column

* Merge remote-tracking branch 'origin/main' into adr033-account-data

# Conflicts:
#	README.md
#	STATUS.json
#	package-lock.json
#	package.json

* account-data: sync the lockfile with openvibe-sdk 0.74.0

Changes

ddiff --git a/README.md b/README.md
iindex af0e765..5965059 100644
---- a/README.md
++++ b/README.md
@@@ -317,7 +317,7 @@ Production: `/opt/openvibe.wiki`, env `/etc/openvibe/wiki.env`, unit
    `openvibe-sdk/db`; Valkey holds the per-actor limit counters (optional: without `VALKEY_URL` they count per process).
  - `openvibe-publishing` v1.3.0 (async PostgreSQL stores, ingest and publication chassis), `openvibe-contracts`
    v0.107.0, `openvibe-shared` v4.48.0
--  (Frame, release, metrics, readiness, SEO helpers, legal pages), `openvibe-sdk` v0.67.0 (db, auth, PostgreSQL
++  (Frame, release, metrics, readiness, SEO helpers, legal pages), `openvibe-sdk` v0.74.0 (db, auth, PostgreSQL
    events outbox, per-actor limits, account export and deletion, testing) — pinned release tarballs.
  - OpenVibe.Network (SSO, JWKS, service principal `wiki`), OpenVibe.Events, OpenVibe.Community,
    OpenVibe.Sources, OpenVibe.Media, OpenVibe.VIP (VIP spaces and pages), OpenVibe.Search (consumer of
@@@ -445,7 +445,7 @@ Part of the [OpenVibe network](https://openvibe.network). Built in the open by [
  
  <!-- versions:start -->
  - openvibe-contracts: v0.222.0
--- openvibe-sdk: v0.67.0
++- openvibe-sdk: v0.74.0
  - openvibe-shared: v4.48.0
  - openvibe-publishing: v1.3.0
  <!-- versions:end -->
ddiff --git a/STATUS.json b/STATUS.json
iindex ecfc723..851991e 100644
---- a/STATUS.json
++++ b/STATUS.json
@@@ -8,12 +8,12 @@
    "port": 4800,
    "domain": "openvibe.wiki",
    "contracts": "openvibe-contracts v0.222.0",
--  "sdk": "openvibe-sdk v0.67.0",
++  "sdk": "openvibe-sdk v0.74.0",
    "shared": "openvibe-shared v4.48.0",
    "packages": [
      "openvibe-publishing v1.3.0",
      "openvibe-shared v4.48.0",
--    "openvibe-sdk v0.67.0"
++    "openvibe-sdk v0.74.0"
    ],
    "capabilities": [
      "wiki.space.create",
ddiff --git a/package-lock.json b/package-lock.json
iindex 6956ecf..b4a7800 100644
---- a/package-lock.json
++++ b/package-lock.json
@@@ -16,7 +16,7 @@
          "iovalkey": "^0.4.0",
          "openvibe-contracts": "https://codeload.github.com/OpenVibers/OpenVibe.Contracts/tar.gz/refs/tags/v0.222.0",
          "openvibe-publishing": "https://codeload.github.com/OpenVibers/OpenVibe.Publishing/tar.gz/refs/tags/v1.3.0",
--        "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.67.0",
++        "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.74.0",
          "openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.48.0",
          "pg": "^8.23.0"
        },
@@@ -1168,9 +1168,9 @@
        }
      },
      "node_modules/openvibe-sdk": {
--      "version": "0.67.0",
--      "resolved": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.67.0",
--      "integrity": "sha512-s7NzjaNcowVcOIiup2z0ze+xsq/qnr++3pHSI8JzirqJPQ5JsBSUF5RkjOHyfk9bRKlmhY0fsNS6x4dsYylyqw==",
++      "version": "0.74.0",
++      "resolved": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.74.0",
++      "integrity": "sha512-DO9KVPnUriY/I4lX6ZEJtXaUvRDbJyqnqJxvlpl+zkNGFILpmuBXVJogNOCfK071Qci1gg7C4Iw1Xrseklcajg==",
        "license": "MIT",
        "bin": {
          "openvibe-download": "bin/openvibe-download.js"
ddiff --git a/package.json b/package.json
iindex 2640d1e..5d3961f 100644
---- a/package.json
++++ b/package.json
@@@ -27,7 +27,7 @@
      "iovalkey": "^0.4.0",
      "openvibe-contracts": "https://codeload.github.com/OpenVibers/OpenVibe.Contracts/tar.gz/refs/tags/v0.222.0",
      "openvibe-publishing": "https://codeload.github.com/OpenVibers/OpenVibe.Publishing/tar.gz/refs/tags/v1.3.0",
--    "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.67.0",
++    "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.74.0",
      "openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.48.0",
      "pg": "^8.23.0"
    },
ddiff --git a/test/account-data.test.js b/test/account-data.test.js
iindex 51f5e36..61fc629 100644
---- a/test/account-data.test.js
++++ b/test/account-data.test.js
@@@ -9,9 +9,10 @@
   */
  const assert = require('assert');
  const http = require('http');
--const { createNetworkSender } = require('openvibe-sdk/account-data');
++const { createNetworkSender, uncovered } = require('openvibe-sdk/account-data');
  const { signDeliveryHeaders } = require('openvibe-sdk/events');
  const H = require('./helpers');
++const { TABLES } = require('../server/wiki/account-data');
  
  const SECRET = `whsec_${'fixture'.repeat(6)}`;
  
@@@ -42,6 +43,18 @@ async function check(name, fn) {
      const alice = { kind: 'user', subject: H.subject() };
      const bob = { kind: 'user', subject: H.subject() };
      const db = h.db;
++    {
++        const missing = await uncovered(db, {
++            tables: TABLES,
++            taskKeyed: ['wiki_spaces', 'wiki_pages', 'wiki_module_dirty', 'wiki_module_pushes'],
++            exempt: {
++                account_data_events: 'the ledger of requests itself: which export and deletion Wiki applied',
++                wiki_index_revisions: "owner is the search-index document's owner (type/id), not a person; the row holds a revision and hash",
++            },
++        });
++        if (missing.length) { failures++; console.log(`  ✗ every table that names a person is covered or exempted with a reason\n      ${missing.join(', ')}`); }
++        else console.log('  ✓ every table that names a person is covered or exempted with a reason');
++    }
      const count = async (sql, args) => Number(await db.value(sql, args));
      const deliver = async (event, { secret = SECRET, headers = {} } = {}) => {
          const body = JSON.stringify({ event, seq: 1 });