openvibers/openvibe.vision Commits

openvibe-shared v4.186.0 (was v4.183.0) (#140)

OP OpenVibers committed 3 days ago · 71d312c1ed · 6 files, +11 −11

* openvibe-shared v4.186.0 (was v4.183.0)

Opened by scripts/pin-bump.js in OpenVibers/OpenVibe.Shared after the v4.186.0 release.

* Fix the openvibe-shared v4.186.0 red checks

openvibe-shared 4.184.0 puts the navbar's links in the first HTML (frame.serverNav)
instead of a <noscript> nav, so the no-JavaScript checks assert the nav that is really
served; the home's size budgets are raised to the sizes this PR measured.

Changes

ddiff --git a/README.md b/README.md
iindex ce9fbbe..0808bf8 100644
---- a/README.md
++++ b/README.md
@@@ -327,5 +327,5 @@ Offer discovery is configured by `VISION_DEALS_SEARCH_URL` and `VISION_SHOES_SEA
  <!-- versions:start -->
  - openvibe-contracts: v0.384.0
  - openvibe-sdk: v0.125.0
--- openvibe-shared: v4.183.0
++- openvibe-shared: v4.186.0
  <!-- versions:end -->
ddiff --git a/STATUS.json b/STATUS.json
iindex 6c68155..d3a8091 100644
---- a/STATUS.json
++++ b/STATUS.json
@@@ -10,11 +10,11 @@
    "domain": "openvibe.vision",
    "contracts": "openvibe-contracts v0.384.0",
    "sdk": "openvibe-sdk v0.125.0",
--  "shared": "openvibe-shared v4.183.0",
++  "shared": "openvibe-shared v4.186.0",
    "packages": [
      "openvibe-contracts v0.384.0",
      "openvibe-sdk v0.125.0",
--    "openvibe-shared v4.179.0"
++    "openvibe-shared v4.186.0"
    ],
    "capabilities": [
      "vision.image.ask",
ddiff --git a/package-lock.json b/package-lock.json
iindex ea7be0f..68988c0 100644
---- a/package-lock.json
++++ b/package-lock.json
@@@ -20,7 +20,7 @@
          "onnxruntime-node": "^1.31.1",
          "openvibe-contracts": "https://codeload.github.com/OpenVibers/OpenVibe.Contracts/tar.gz/refs/tags/v0.384.0",
          "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.125.0",
--        "openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.183.0",
++        "openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.186.0",
          "pg": "^8.23.0",
          "sharp": "^0.33.5"
        },
@@@ -2669,9 +2669,9 @@
        }
      },
      "node_modules/openvibe-shared": {
--      "version": "4.183.0",
--      "resolved": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.183.0",
--      "integrity": "sha512-vp9gg++Dhyj3h0cwvBjujM6dSFYoeXdh1UXdZ6OXP/NjG672Fs7uRANV4MjT467JtFDN7r7qLI3OJAwGQxOuQw==",
++      "version": "4.186.0",
++      "resolved": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.186.0",
++      "integrity": "sha512-wD4net+UjO0a6OG73W+RR1z5MIWtPgj407xLEWphiVWgLTQ4V1r76+DtLOfSf6RfEda/ALizRu1zmxbvuGGZOw==",
        "license": "MIT",
        "dependencies": {
          "jsonwebtoken": "^9.0.0",
ddiff --git a/package.json b/package.json
iindex c36bfde..ebc2e38 100644
---- a/package.json
++++ b/package.json
@@@ -30,7 +30,7 @@
      "onnxruntime-node": "^1.31.1",
      "openvibe-contracts": "https://codeload.github.com/OpenVibers/OpenVibe.Contracts/tar.gz/refs/tags/v0.384.0",
      "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.125.0",
--    "openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.183.0",
++    "openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.186.0",
      "pg": "^8.23.0",
      "sharp": "^0.33.5"
    },
ddiff --git a/test/pages.test.js b/test/pages.test.js
iindex 6696e3d..327b351 100644
---- a/test/pages.test.js
++++ b/test/pages.test.js
@@@ -26,7 +26,7 @@ const PLANTED = '<style>body{background:#fff;color:#999}.wide{width:1600px}</sty
              assert.strictEqual(r.status, 200);
              assert.strictEqual(r.headers.get('cache-control'), 'public, max-age=60');
              assert.strictEqual(r.headers.get('vary'), 'Cookie');
--            for (const marker of ['id="vi-home"', 'id="vi-try"', 'class="sc-room-scenes"', '<noscript><nav', '<footer id="ov-footer"', '<main id="main"', '/ask', '/ocr', '/compare', '/ui-check']) assert.ok(r.text.includes(marker), marker);
++            for (const marker of ['id="vi-home"', 'id="vi-try"', 'class="sc-room-scenes"', '<div id="navbar-mount"><nav', '<footer id="ov-footer"', '<main id="main"', '/ask', '/ocr', '/compare', '/ui-check']) assert.ok(r.text.includes(marker), marker);
              const types = jsonLd(r.text).map((x) => x['@type']);
              assert.ok(types.includes('WebSite'), types.join(','));
              assert.ok(types.includes('WebApplication'), types.join(','));
ddiff --git a/test/sso.test.js b/test/sso.test.js
iindex c83418c..48d11b7 100644
---- a/test/sso.test.js
++++ b/test/sso.test.js
@@@ -130,11 +130,11 @@ const cookieJar = (res) => res.headers.getSetCookie().map((c) => c.split(';')[0]
          assert.notStrictEqual(proxied.status, 200, 'a proxied request is not loopback');
      });
  
--    await check('public pages are complete without JavaScript', async () => {
++    await check('public pages are complete without JavaScript (server-rendered nav, SSR footer)', async () => {
          for (const p of ['/', '/developers']) {
              const r = await t.get(p);
              assert.strictEqual(r.status, 200, p);
--            assert.match(r.text, /<noscript><nav/);
++            assert.match(r.text, /<div id="navbar-mount"><nav class="openvibe-navbar"[^>]*data-ov-server-nav="true"/, `${p}: the server-rendered navbar is in the first HTML`);
              assert.match(r.text, /<footer id="ov-footer"/);
              assert.match(r.text, /<main id="main"/);
          }