openvibers/openvibe.tours Commits

A city's place rows say 'free to visit', not 'free' after 'step-free' (#51)

OP OpenVibers committed 11 days ago · 07d710c78d · 2 files, +17 −1

/city/delhi read 'step-free · free': two facts, but it looked like the
same word twice (the text sweep of 2026-11-02 flagged it).

Changes

ddiff --git a/server/views/index.js b/server/views/index.js
iindex 2c6cb0e..4dee337 100644
---- a/server/views/index.js
++++ b/server/views/index.js
@@@ -250,7 +250,7 @@ ${img ? `<figure class="tr-city-img"><img src="${esc(img)}" alt="${esc(city.name
  </header>
  ${routes.length ? `<section class="tr-sec"><div class="tr-sec-head"><h2>Self-guided routes</h2><span class="tr-muted">generated from Wikivoyage's See list</span></div><ol class="tr-route-list">${routes.map((r) => `<li><a href="/routes/${esc(r.id)}"><strong>${esc(r.title)}</strong><span class="tr-muted">${Number(r.stop_count)} stops · ${km(r.distance_m)} · ${Number(r.duration_min)} min</span></a></li>`).join('')}</ol></section>` : ''}
  <section class="tr-sec" id="tr-city-places"><div class="tr-sec-head"><h2>Places</h2><a class="tr-more" href="https://www.openstreetmap.org/?mlat=${city.lat}&mlon=${city.lon}#map=13/${city.lat}/${city.lon}" rel="noopener">OpenStreetMap</a></div>
--${places.length ? `<ol class="tr-place-list">${places.map((p) => `<li class="tr-place-row"><a href="/place/${esc(p.id)}"><strong>${esc(placeName(p))}</strong><span class="tr-muted">${esc([localName(p), kindUnlessNamed(p), p.address, p.wheelchair === 'yes' ? 'step-free' : '', p.fee === 'no' ? 'free' : ''].filter(Boolean).join(' · '))}</span></a></li>`).join('')}</ol>` : empty('No OpenStreetMap place was stored for this city yet. The places job fills it.', '/cities', 'Another city')}
++${places.length ? `<ol class="tr-place-list">${places.map((p) => `<li class="tr-place-row"><a href="/place/${esc(p.id)}"><strong>${esc(placeName(p))}</strong><span class="tr-muted">${esc([localName(p), kindUnlessNamed(p), p.address, p.wheelchair === 'yes' ? 'step-free' : '', p.fee === 'no' ? 'free to visit' : ''].filter(Boolean).join(' · '))}</span></a></li>`).join('')}</ol>` : empty('No OpenStreetMap place was stored for this city yet. The places job fills it.', '/cities', 'Another city')}
  <p class="tr-fine">${SOURCE.osm}</p></section>
  ${live.length ? `<section class="tr-sec"><div class="tr-sec-head"><h2>Live tours and recordings</h2><a class="tr-more" href="/live">All live</a></div><ol class="tr-live-list">${live.map((l) => `<li><a href="${esc(l.url)}" rel="noopener"><strong>${esc(l.title)}</strong><span class="tr-muted">${esc(l.kind === 'stream' ? 'Live now' : l.kind === 'clip' ? 'Clip' : 'Recording')} · ${esc(l.display_name || l.username)}${l.city_name ? ` · ${esc(l.city_name)}` : ''}${l.kind === 'stream' ? ` · ${Number(l.viewer_count)} watching` : ''}</span></a></li>`).join('')}</ol><p class="tr-fine">OpenVibe.Live's public stream list · fetched ${when(live[0].fetched_at)}</p></section>` : ''}
  ${stays.length ? `<section class="tr-sec"><div class="tr-sec-head"><h2>Stays</h2><a class="tr-more" href="/stays">All stays</a></div><ol class="tr-stay-list">${stays.map((s0) => `<li><a href="${esc(s0.url)}" rel="noopener"><strong>${esc(s0.title)}</strong><span class="tr-muted">${esc(s0.kind)} · ${money(s0.price, s0.currency)} / ${esc(s0.period)}${s0.neighbourhood ? ` · ${esc(s0.neighbourhood)}` : ''}</span></a></li>`).join('')}</ol><p class="tr-fine">OpenVibe.Rent's public listings · never a payment on Tours.</p></section>` : ''}
ddiff --git a/test/place-row-facts.test.js b/test/place-row-facts.test.js
nnew file mode 100644
iindex 0000000..0351515
---- /dev/null
++++ b/test/place-row-facts.test.js
@@@ -0,0 +1,16 @@
++'use strict';
++/**
++ * A city's place rows say each fact once and plainly: "step-free · free to visit", not "step-free · free" (which read as
++ * the same word twice on /city/delhi, 2026-11-02).
++ *
++ *   node test/place-row-facts.test.js
++ */
++const assert = require('assert');
++const views = require('../server/views');
++
++const city = { slug: 'delhi', name: 'Delhi', country: 'India', summary: 'The capital.', lat: 28.6, lon: 77.2 };
++const place = { id: 'plc_1', name: 'Grass Sculptures', kind: 'artwork', address: 'Netaji Subhash Marg, 110006, Delhi', wheelchair: 'yes', fee: 'no', lat: 28.6, lon: 77.2 };
++const html = views.cityPage({ city, places: [place] });
++assert.ok(html.includes('step-free · free to visit'), 'both facts, each said once');
++assert.ok(!/step-free · free(?! to visit)/.test(html), 'never "step-free · free"');
++console.log('place row facts: step-free · free to visit');