openvibers/openvibe.search Commits

Search: /updates has one heading (the log's own) (#57)

OP OpenVibers committed 29 days ago · ecd615be3b · 2 files, +5 −3

`/updates` has one heading. The site-wide crawl found two `<h1>` there: the search page's "OpenVibe.Search" header and the update log's own "What shipped on OpenVibe.Search".

`layout()` takes `ownHeading`. `/updates` sets it, which leaves out the search page's heading and lede but keeps the search box. `test/page.test.js` asserts exactly one `<h1>`.

Changes

ddiff --git a/server/web/page.js b/server/web/page.js
iindex 8fa4e88..abed42b 100644
---- a/server/web/page.js
++++ b/server/web/page.js
@@@ -219,7 +219,8 @@ function frontShowcase(owners = DEFAULT_EVENT_OWNERS) {
      return showcase.features({ id: 'sources', title: 'Browse by source', lede: 'Each service sends what it publishes as it publishes it; open one to see its public documents.', items });
  }
  
--function layout({ title, q, owner, type, body, noindex, canonical, jsonLd, front = false }) {
++// ownHeading: the body brings its own <h1> (the update log), so the search page's heading and lede stay out.
++function layout({ title, q, owner, type, body, noindex, canonical, jsonLd, front = false, ownHeading = false }) {
      const url = noindex ? undefined : canonical;
      return shell.page({
          ...FRAME,
@@@ -269,7 +270,7 @@ ${front ? showcase.hero({
          eyebrow: 'OpenVibe.Search',
          title: 'Search the', accent: 'OpenVibe network',
          lede: "Wiki pages, posts, stories, pastes, tools and more from the network's services, in one index. Alpha: it holds only what they have sent so far.",
--    }) : `<h1><a href="/" style="color:inherit;text-decoration:none">OpenVibe.Search</a></h1>
++    }) : ownHeading ? '' : `<h1><a href="/" style="color:inherit;text-decoration:none">OpenVibe.Search</a></h1>
  <p class="lede">Search what the OpenVibe network's services have published. Alpha: the index holds only what they have sent so far.</p>`}
  <form method="get" action="/" role="search">
  <input type="search" name="q" value="${esc(q)}" maxlength="500" placeholder="Search the network" aria-label="Search terms" autofocus>
@@@ -309,7 +310,7 @@ function pageRouter({ searcher, auth, baseUrl = 'https://search.openvibe.network
          res.setHeader('Content-Security-Policy', CSP);
          res.setHeader('X-Frame-Options', 'DENY');
          res.setHeader('Cache-Control', cache.htmlHeaders({ maxAge: 60 }));
--        res.type('html').send(layout({ title: 'What shipped on OpenVibe.Search', q: '', owner: '', type: '', body: frame.updatesBody({ service: 'search', siteName: 'OpenVibe.Search' }) + `<script src="${ovServe.url('shipped.js')}" defer></script>`, canonical: `${origin}/updates` }));
++        res.type('html').send(layout({ title: 'What shipped on OpenVibe.Search', q: '', owner: '', type: '', ownHeading: true, body: frame.updatesBody({ service: 'search', siteName: 'OpenVibe.Search' }) + `<script src="${ovServe.url('shipped.js')}" defer></script>`, canonical: `${origin}/updates` }));
      });
  
      // Crawl files (openvibe-shared/seo): the existing robots rules kept, plus /llms.txt and /sitemap.xml.
ddiff --git a/test/page.test.js b/test/page.test.js
iindex d34cdeb..49802c4 100644
---- a/test/page.test.js
++++ b/test/page.test.js
@@@ -100,6 +100,7 @@ t('/updates is the shared log; the old Frame init script is gone', async () => {
      assert.strictEqual(r.status, 200);
      assert.ok(r.text.includes('What shipped on OpenVibe.Search') && r.text.includes('data-ov-shipped="log" data-service="search"'));
      assert.match(r.text, /<link rel="canonical" href="https?:\/\/[^"/]+\/updates">/);
++    assert.strictEqual((r.text.match(/<h1[\s>]/g) || []).length, 1, 'one heading: the log\'s own');
      assert.match(r.text, /<meta name="ov-boost" content="search@[^"]+">/);
      assert.match(r.headers.get('content-security-policy'), /default-src 'none'/);
  });