openvibers/openvibe.network Commits

Network: Codes takes part in account export and deletion (its coding tasks) (#179)

OP OpenVibers committed 30 days ago · 4166480ced · 2 files, +5 −4

* Network: Codes takes part in account export and deletion (its coding tasks)

ADR-033, last step of the recipe for OpenVibe.Codes, whose `run_tasks` are people's coding tasks (Codes#62).

**Already done, in order**
- Network#178 granted `events.subscription.manage`.
- Codes deployed with `CODES_EVENTS_SECRET` and its nginx `/internal/` rule (outside → 404).
- On restart Codes created both subscriptions, `network.account.export_requested` and `network.account.deleted`, delivering to `127.0.0.1:4900/internal/events`.
- An unsigned loopback POST gets 401.

**This PR:** `codes` joins the holders of `network.account.export.contribute` and `network.account.deletion.confirm`. Network will now wait for Codes' export part (`run-tasks.json`) and its deletion confirmation.

**Tests:** `principals` passes.

* Network: account-data test counts Codes among the export holders

Changes

ddiff --git a/server/identity/principals.js b/server/identity/principals.js
iindex 9ce0a9cc..b8689812 100644
---- a/server/identity/principals.js
++++ b/server/identity/principals.js
@@@ -111,8 +111,9 @@ const DEFAULT_GRANTS = [
      // confirm a deletion; the holders of each grant are the services Network waits for.
      // Since 2026-10-08 the services built from the skeleton answer too, through openvibe-sdk/account-data (SDK 0.36.0),
      // and since 2026-10-09 the older services that hold personal rows (SDK 0.37.0; each subscribed before this grant).
++    // Codes since 2026-10-14 (its run_tasks, plan T16; subscribed first through Network#178).
      ...['live', 'chat', 'community', 'media', 'games', 'actor', 'food', 'help', 'work', 'quest', 'rent', 'media-hub',
--        'deals', 'trade', 'tips', 'vip', 'watch', 'services', 'wiki', 'blog', 'bot', 'inventory'].flatMap((svc) => [
++        'deals', 'trade', 'tips', 'vip', 'watch', 'services', 'wiki', 'blog', 'bot', 'inventory', 'codes'].flatMap((svc) => [
          [svc, 'network.account.export.contribute', SELF_AUDIENCE, []],
          [svc, 'network.account.deletion.confirm', SELF_AUDIENCE, []],
      ]),
ddiff --git a/test/account-data.test.js b/test/account-data.test.js
iindex 33c705c4..921bd2ed 100644
---- a/test/account-data.test.js
++++ b/test/account-data.test.js
@@@ -93,11 +93,11 @@ const server = http.createServer(app);
  
          // ── Export ──
          const seeded = await accountData.expectedServices(db, 'network.account.export.contribute');
--        assert.deepStrictEqual(seeded, ['actor', 'blog', 'bot', 'chat', 'community', 'deals', 'food', 'games', 'help', 'inventory', 'live', 'media', 'media-hub', 'quest', 'rent', 'services', 'tips', 'trade', 'vip', 'watch', 'wiki', 'work'],
--            'the holders of the contribute grant: the skeleton services answer too since 2026-10-08 and the older ones since 2026-10-09 (openvibe-sdk/account-data); Space left with the forum');
++        assert.deepStrictEqual(seeded, ['actor', 'blog', 'bot', 'chat', 'codes', 'community', 'deals', 'food', 'games', 'help', 'inventory', 'live', 'media', 'media-hub', 'quest', 'rent', 'services', 'tips', 'trade', 'vip', 'watch', 'wiki', 'work'],
++            'the holders of the contribute grant: the skeleton services answer too since 2026-10-08 and the older ones since 2026-10-09 (openvibe-sdk/account-data); Space left with the forum; Codes since 2026-10-14 (its run tasks)');
          // The scenarios below follow five services; the newer ones are set aside here, exactly as an operator would
          // revoke a service's grant (the same rows, the same revoked_at).
--        for (const svc of ['actor', 'blog', 'bot', 'deals', 'food', 'help', 'inventory', 'media-hub', 'quest', 'rent', 'services', 'tips', 'trade', 'vip', 'watch', 'wiki', 'work']) {
++        for (const svc of ['actor', 'blog', 'bot', 'codes', 'deals', 'food', 'help', 'inventory', 'media-hub', 'quest', 'rent', 'services', 'tips', 'trade', 'vip', 'watch', 'wiki', 'work']) {
              for (const cap of ['network.account.export.contribute', 'network.account.deletion.confirm']) {
                  await db.prepare('UPDATE principal_grants SET revoked_at = ov_now() WHERE client_id = ? AND capability = ? AND revoked_at IS NULL').run(svc, cap);
              }