openvibers/openvibe.mediahub Commits
Guide the video upload step (#394)
Changes
@@@ -241,7 +241,7 @@ ${cuts.length ? html`<ul class="ovv-cuts">${cuts.map(cutLine)}</ul>` : ''}scripts: ['js/video-upload.js'],body: html`<h1>Upload a video</h1><form class="ovv-upload ovv-panel" data-video-upload method="post" action="/upload">--<div class="ovv-upload-pick"><div data-ov-upload-picker></div>++<div class="ovv-upload-pick"><div data-ov-upload-picker data-ov-guide="video.upload"></div><ov-progress data-ov-upload-progress hidden></ov-progress></div><div class="ovv-upload-details"><label class="ovv-field"><span>Title</span><input name="title" type="text" maxlength="120" required></label>@@@ -75,6 +75,7 @@ function vreq(base, path, { method = 'GET', cookie, form, json, body, same = truawait check('upload page uses the shared picker, progress and a rules sheet', async () => {const page = await vreq(t.base, '/upload', { cookie: kimCookie });assert.strictEqual(page.status, 200, page.text.slice(0, 180));++ assert.ok(page.text.includes('data-ov-upload-picker data-ov-guide="video.upload"'), 'the upload picker has the Quest guide target');assert.ok(page.text.includes('/shared/ov-upload.js') && page.text.includes('/shared/ov-upload.css'));assert.ok(page.text.includes('<ov-progress') && page.text.includes('data-ov-upload-picker'));assert.ok(page.text.includes('data-upload-rules-sheet'));
@@ -241,7 +241,7 @@ ${cuts.length ? html`<ul class="ovv-cuts">${cuts.map(cutLine)}</ul>` : ''}
@@ -241,7 +241,7 @@ ${cuts.length ? html`<ul class="ovv-cuts">${cuts.map(cutLine)}</ul>` : ''}
scripts: ['js/video-upload.js'],
scripts: ['js/video-upload.js'],
body: html`<h1>Upload a video</h1>
body: html`<h1>Upload a video</h1>
<form class="ovv-upload ovv-panel" data-video-upload method="post" action="/upload">
<form class="ovv-upload ovv-panel" data-video-upload method="post" action="/upload">
-<div class="ovv-upload-pick"><div data-ov-upload-picker></div>
+<div class="ovv-upload-pick"><div data-ov-upload-picker data-ov-guide="video.upload"></div>
<ov-progress data-ov-upload-progress hidden></ov-progress></div>
<ov-progress data-ov-upload-progress hidden></ov-progress></div>
<div class="ovv-upload-details">
<div class="ovv-upload-details">
<label class="ovv-field"><span>Title</span><input name="title" type="text" maxlength="120" required></label>
<label class="ovv-field"><span>Title</span><input name="title" type="text" maxlength="120" required></label>
@@ -75,6 +75,7 @@ function vreq(base, path, { method = 'GET', cookie, form, json, body, same = tru
@@ -75,6 +75,7 @@ function vreq(base, path, { method = 'GET', cookie, form, json, body, same = tru
await check('upload page uses the shared picker, progress and a rules sheet', async () => {
await check('upload page uses the shared picker, progress and a rules sheet', async () => {
const page = await vreq(t.base, '/upload', { cookie: kimCookie });
const page = await vreq(t.base, '/upload', { cookie: kimCookie });
assert.strictEqual(page.status, 200, page.text.slice(0, 180));
assert.strictEqual(page.status, 200, page.text.slice(0, 180));
+ assert.ok(page.text.includes('data-ov-upload-picker data-ov-guide="video.upload"'), 'the upload picker has the Quest guide target');
assert.ok(page.text.includes('/shared/ov-upload.js') && page.text.includes('/shared/ov-upload.css'));
assert.ok(page.text.includes('/shared/ov-upload.js') && page.text.includes('/shared/ov-upload.css'));
assert.ok(page.text.includes('<ov-progress') && page.text.includes('data-ov-upload-picker'));
assert.ok(page.text.includes('<ov-progress') && page.text.includes('data-ov-upload-picker'));
assert.ok(page.text.includes('data-upload-rules-sheet'));
assert.ok(page.text.includes('data-upload-rules-sheet'));