openvibers/openvibe.live Commits

test/rollback-newer-writes.test.js — git failures no longer skip the…

OP OpenVibers committed 1 Oct 2026 · bfe3d93f7e · 1 file, +14 −2

Done by the harness job live-branch-off-main-at-or-211228.

Changes

ddiff --git a/test/rollback-newer-writes.test.js b/test/rollback-newer-writes.test.js
iindex 524c303c..85155ca6 100644
---- a/test/rollback-newer-writes.test.js
++++ b/test/rollback-newer-writes.test.js
@@@ -19,8 +19,20 @@ const { execFileSync, spawnSync } = require('child_process');
const { oldRelease } = require('./helpers/old-release');
const ROOT = path.join(__dirname, '..');
--const git = (...a) => { try { return execFileSync('git', ['-C', ROOT, ...a], { encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'] }).trim(); } catch { return ''; } };
--const old = process.env.ROLLBACK_REF || git('log', '-1', '--before=7 days ago', '--format=%H');
++// Only a clone with no commit older than a week (a shallow CI clone) may skip: a failing git (missing
++// binary, not a repository, locked metadata) is a broken environment, not a reason to pass silently.
++let old = process.env.ROLLBACK_REF;
++if (!old) {
++ let probe;
++ try {
++ probe = execFileSync('git', ['-C', ROOT, 'log', '-1', '--before=7 days ago', '--format=%H'], { encoding: 'utf8', stdio: ['ignore', 'pipe', 'pipe'] });
++ } catch (e) {
++ console.error('rollback with newer writes: git could not find a release older than 7 days:');
++ console.error(String(e.stderr || e.message || e).trim());
++ process.exit(1);
++ }
++ old = String(probe).trim();
++}
if (!old) { console.log('rollback with newer writes: skipped (no git history to take the older release from)'); process.exit(0); }
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'ov-live-rollback-'));