Knowledge: a note that needs review shows it (#419)

OP OpenVibers committed 2 days ago · e0fdafe4f9 · 2 files, +5 −2

A fact or lesson the nightly tidy could not support is held back from the next run; its "Needs review" pill was the
same grey as "Fact". It is amber now, and the card has an amber left edge.

Changes

ddiff --git a/public/css/c4.css b/public/css/c4.css
iindex a68352f..c6e89e9 100644
---- a/public/css/c4.css
++++ b/public/css/c4.css
@@@ -331,6 +331,9 @@
  .kn-row{padding:14px 16px;border-left:3px solid transparent}
  .kn-row.is-pinned{border-left-color:var(--c4-accent)}
  .kn-row-head{display:flex;flex-wrap:wrap;align-items:center;gap:6px;margin-bottom:8px;min-width:0}
++/* A note the nightly tidy could not support is held back from the next run: an amber edge and an amber pill, so it is
++   found before it is trusted (Opus, 2026-11-11). */
++.kn-row.is-review{box-shadow:inset 3px 0 0 var(--c4-dot-bad)}
  .kn-repo{overflow-wrap:anywhere}
  .kn-text{margin:0 0 8px;font-size:14px;line-height:1.55;color:var(--c4-ink);overflow-wrap:anywhere;white-space:pre-wrap}
  .kn-meta{margin:0 0 4px;font-size:12px;color:var(--c4-muted)}
ddiff --git a/server/http/knowledge.js b/server/http/knowledge.js
iindex 1ddc26d..68af37d 100644
---- a/server/http/knowledge.js
++++ b/server/http/knowledge.js
@@@ -119,8 +119,8 @@ ${row.visibility === 'team' ? `<form method="post" action="/knowledge/${esc(row.
              : '<span class="c4-hint">No team to share with yet.</span>')}
  <details class="c4-more kn-delete"><summary>Delete</summary><div class="c4-more-body"><p class="kn-confirm">Delete this ${row.kind === 'fact' ? 'fact' : 'lesson'}? Runs stop recalling it, and it cannot be brought back.</p><form method="post" action="/knowledge/${esc(row.id)}/delete"><input type="hidden" name="tab" value="${esc(tab)}"><button class="c4-button c4-button-danger" type="submit">Delete it</button></form></div></details>
  </div>` : `<p class="kn-team-note">${row.visibility === 'team' ? 'Shared with your team.' : ''} Only ${mine ? 'you' : 'its owner'} can edit it.</p>`;
--        return `<article class="c4-card kn-row${row.pinned ? ' is-pinned' : ''}">
--<div class="kn-row-head">${pill(row.kind === 'fact' ? 'Fact' : 'Lesson')}${row.pinned ? pill('Pinned', 'pinned') : ''}${row.dream_status === 'unsupported' ? pill('Needs review') : ''}${shared}</div>
++        return `<article class="c4-card kn-row${row.pinned ? ' is-pinned' : ''}${row.dream_status === 'unsupported' ? ' is-review' : ''}">
++<div class="kn-row-head">${pill(row.kind === 'fact' ? 'Fact' : 'Lesson')}${row.pinned ? pill('Pinned', 'pinned') : ''}${row.dream_status === 'unsupported' ? pill('Needs review', 'bad') : ''}${shared}</div>
  <p class="kn-text">${esc(row.text)}</p>
  <p class="kn-meta">${esc(dayOf(row.last_seen_at))}${row.seen > 1 ? ` · seen ${row.seen} times` : ''}${row.redacted ? ' · secrets removed' : ''}${row.dream_status === 'unsupported' ? ' · not sent to the next run' : ''}</p>
  ${source}${actions}

diff --git a/public/css/c4.css b/public/css/c4.css

index a68352f..c6e89e9 100644

--- a/public/css/c4.css

+++ b/public/css/c4.css

@@ -331,6 +331,9 @@

.kn-row{padding:14px 16px;border-left:3px solid transparent}

.kn-row.is-pinned{border-left-color:var(--c4-accent)}

.kn-row-head{display:flex;flex-wrap:wrap;align-items:center;gap:6px;margin-bottom:8px;min-width:0}

+/* A note the nightly tidy could not support is held back from the next run: an amber edge and an amber pill, so it is

+ found before it is trusted (Opus, 2026-11-11). */

+.kn-row.is-review{box-shadow:inset 3px 0 0 var(--c4-dot-bad)}

.kn-repo{overflow-wrap:anywhere}

.kn-text{margin:0 0 8px;font-size:14px;line-height:1.55;color:var(--c4-ink);overflow-wrap:anywhere;white-space:pre-wrap}

.kn-meta{margin:0 0 4px;font-size:12px;color:var(--c4-muted)}

diff --git a/server/http/knowledge.js b/server/http/knowledge.js

index 1ddc26d..68af37d 100644

--- a/server/http/knowledge.js

+++ b/server/http/knowledge.js

@@ -119,8 +119,8 @@ ${row.visibility === 'team' ? `<form method="post" action="/knowledge/${esc(row.

: '<span class="c4-hint">No team to share with yet.</span>')}

<details class="c4-more kn-delete"><summary>Delete</summary><div class="c4-more-body"><p class="kn-confirm">Delete this ${row.kind === 'fact' ? 'fact' : 'lesson'}? Runs stop recalling it, and it cannot be brought back.</p><form method="post" action="/knowledge/${esc(row.id)}/delete"><input type="hidden" name="tab" value="${esc(tab)}"><button class="c4-button c4-button-danger" type="submit">Delete it</button></form></div></details>

</div>` : `<p class="kn-team-note">${row.visibility === 'team' ? 'Shared with your team.' : ''} Only ${mine ? 'you' : 'its owner'} can edit it.</p>`;

- return `<article class="c4-card kn-row${row.pinned ? ' is-pinned' : ''}">

-<div class="kn-row-head">${pill(row.kind === 'fact' ? 'Fact' : 'Lesson')}${row.pinned ? pill('Pinned', 'pinned') : ''}${row.dream_status === 'unsupported' ? pill('Needs review') : ''}${shared}</div>

+ return `<article class="c4-card kn-row${row.pinned ? ' is-pinned' : ''}${row.dream_status === 'unsupported' ? ' is-review' : ''}">

+<div class="kn-row-head">${pill(row.kind === 'fact' ? 'Fact' : 'Lesson')}${row.pinned ? pill('Pinned', 'pinned') : ''}${row.dream_status === 'unsupported' ? pill('Needs review', 'bad') : ''}${shared}</div>

<p class="kn-meta">${esc(dayOf(row.last_seen_at))}${row.seen > 1 ? ` · seen ${row.seen} times` : ''}${row.redacted ? ' · secrets removed' : ''}${row.dream_status === 'unsupported' ? ' · not sent to the next run' : ''}</p>

${source}${actions}