openvibers/openvibe.bot Commits

account-data: pin openvibe-sdk 0.74.0 and guard every table with a person column (#231)

OP OpenVibers committed 14 days ago · bbba1f4356 · 5 files, +26 −11

* account-data: pin openvibe-sdk 0.74.0 and guard every table with a person column

* Merge remote-tracking branch 'origin/main' into adr033-account-data

# Conflicts:
#	README.md
#	STATUS.json
#	package-lock.json
#	package.json

* account-data: sync the lockfile with openvibe-sdk 0.74.0

Changes

ddiff --git a/README.md b/README.md
iindex be9c459..82e2706 100644
---- a/README.md
++++ b/README.md
@@@ -138,7 +138,7 @@ Sitemap entries use the release commit time for these code-backed pages.
  - OpenVibe.Network: user and service tokens, node tokens, pairing when the authority is `network`, and identity resolution (a `@username` to a subject, and subjects to names, for the panel's People card).
  - OpenRestream: the WHIP ingest base (`BOT_WHIP_BASE`) devices publish to.
  - OpenVibe.Billing: job usage readings go to `billing.usage.record` (`BOT_BILLING_URL`; Bot mints its own Network service token for audience `openvibe.billing` with `billing.usage.record`, and `BOT_BILLING_TOKEN` overrides it); unset, they wait in `run_usage_outbox`.
--- `openvibe-contracts` v0.129.0, `openvibe-sdk` v0.67.0 and `openvibe-shared` v4.48.0 (package.json).
++- `openvibe-contracts` v0.129.0, `openvibe-sdk` v0.74.0 and `openvibe-shared` v4.48.0 (package.json).
  - Account export and deletion (ADR-033): Network grants `events.subscription.manage` (openvibe.events) for the two
    subscriptions created at boot, then, last and once the release is live, `network.account.export.contribute` and
    `network.account.deletion.confirm` (openvibe.network).
@@@ -227,6 +227,6 @@ OpenVibe.Sites no longer generates `deploy/nginx/openvibe.bot.conf` (sites.json
  
  <!-- versions:start -->
  - openvibe-contracts: v0.223.0
--- openvibe-sdk: v0.67.0
++- openvibe-sdk: v0.74.0
  - openvibe-shared: v4.48.0
  <!-- versions:end -->
ddiff --git a/STATUS.json b/STATUS.json
iindex 6b57a9f..d758f8f 100644
---- a/STATUS.json
++++ b/STATUS.json
@@@ -6,11 +6,11 @@
    "port": 4630,
    "domain": "openvibe.bot (www -> apex; /device and /control WebSockets; /install)",
    "contracts": "openvibe-contracts v0.223.0",
--  "sdk": "openvibe-sdk v0.67.0",
++  "sdk": "openvibe-sdk v0.74.0",
    "shared": "openvibe-shared v4.48.0",
    "packages": [
      "openvibe-contracts v0.223.0",
--    "openvibe-sdk v0.67.0",
++    "openvibe-sdk v0.74.0",
      "openvibe-shared v4.48.0"
    ],
    "capabilities": [
ddiff --git a/package-lock.json b/package-lock.json
iindex 4d7986d..0e90851 100644
---- a/package-lock.json
++++ b/package-lock.json
@@@ -14,7 +14,7 @@
          "express": "^4.21.2",
          "iovalkey": "^0.4.0",
          "openvibe-contracts": "https://codeload.github.com/OpenVibers/OpenVibe.Contracts/tar.gz/refs/tags/v0.223.0",
--        "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.67.0",
++        "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.74.0",
          "openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.48.0",
          "pg": "^8.23.0",
          "qrcode-generator": "^2.0.4",
@@@ -1136,9 +1136,9 @@
        }
      },
      "node_modules/openvibe-sdk": {
--      "version": "0.67.0",
--      "resolved": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.67.0",
--      "integrity": "sha512-s7NzjaNcowVcOIiup2z0ze+xsq/qnr++3pHSI8JzirqJPQ5JsBSUF5RkjOHyfk9bRKlmhY0fsNS6x4dsYylyqw==",
++      "version": "0.74.0",
++      "resolved": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.74.0",
++      "integrity": "sha512-DO9KVPnUriY/I4lX6ZEJtXaUvRDbJyqnqJxvlpl+zkNGFILpmuBXVJogNOCfK071Qci1gg7C4Iw1Xrseklcajg==",
        "license": "MIT",
        "bin": {
          "openvibe-download": "bin/openvibe-download.js"
ddiff --git a/package.json b/package.json
iindex bddbfe3..1f63181 100644
---- a/package.json
++++ b/package.json
@@@ -2,7 +2,7 @@
    "name": "openvibe-bot",
    "version": "0.1.0",
    "private": true,
--  "description": "OpenVibe.Bot — devices, pairing and control for robots on the OpenVibe network: one outbound WebSocket per device, profiles instead of rows, safety by default.",
++  "description": "OpenVibe.Bot \u2014 devices, pairing and control for robots on the OpenVibe network: one outbound WebSocket per device, profiles instead of rows, safety by default.",
    "main": "server/index.js",
    "scripts": {
      "start": "node server/index.js",
@@@ -26,7 +26,7 @@
      "express": "^4.21.2",
      "iovalkey": "^0.4.0",
      "openvibe-contracts": "https://codeload.github.com/OpenVibers/OpenVibe.Contracts/tar.gz/refs/tags/v0.223.0",
--    "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.67.0",
++    "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.74.0",
      "openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.48.0",
      "pg": "^8.23.0",
      "qrcode-generator": "^2.0.4",
ddiff --git a/test/account-data.test.js b/test/account-data.test.js
iindex 61ae791..bbedd43 100644
---- a/test/account-data.test.js
++++ b/test/account-data.test.js
@@@ -8,9 +8,11 @@
   */
  const assert = require('assert');
  const http = require('http');
--const { createNetworkSender } = require('openvibe-sdk/account-data');
++const { createNetworkSender, uncovered } = require('openvibe-sdk/account-data');
  const { signDeliveryHeaders } = require('openvibe-sdk/events');
  const { boot, check, done } = require('./helpers/app');
++const { TABLES } = require('../server/account-data');
++const { testDb } = require('./helpers/db');
  
  const SECRET = `whsec_${'fixture'.repeat(6)}`;
  
@@@ -31,6 +33,19 @@ async function startNetworkStub() {
  }
  
  (async () => {
++    await check('every table that names a person is covered or exempted with a reason', async () => {
++        const d = await testDb();
++        try {
++            const missing = await uncovered(d.db, {
++                tables: TABLES,
++               
++                taskKeyed: ["robot_routines","robot_webhooks"],
++                exempt: {"account_data_events":"the ledger of requests itself: which export and deletion Bot applied"},
++            });
++            assert.deepStrictEqual(missing, [], `a table with a person column is neither covered nor exempted: ${missing.join(', ')}`);
++        } finally { await d.close(); }
++    });
++
      const stub = await startNetworkStub();
      const t = await boot({ env: { BOT_EVENTS_SECRET: SECRET }, appOpts: { accountSend: createNetworkSender({ networkInternalUrl: stub.url, clientId: 'bot', clientSecret: 'shh' }) } });
      const alex = t.network.newUser('alex');