openvibers/openvibe.bench Commits

One sign-in module: openvibe-sdk/sso 0.73.0 (#14)

OP OpenVibers committed 14 days ago · 18f2917d83 · 7 files, +304 −147

The site's own copy of the sign-in module is gone. server/auth/sso.js is now a thin wrapper around
createSsoClient from openvibe-sdk/sso (0.73.0): the routes, the middleware and the shapes the pages
still read, nothing else.

What this buys:
- a lost or expired flow, or a code the Network no longer accepts, starts the sign-in once more by itself;
  when it cannot, the visitor gets a page with "Try again" instead of a bare "The Network refused the
  sign-in code. Please sign in again."
- a client the Network refuses is logged as a configuration error, and GET /auth/health answers
  {"ok":true,"client":"ok"} (503 when it is refused).
- GET /api/ready now answers 503 when the Network refuses this site's OAuth client, so a deploy with a
  wrong secret fails at once. 'unknown' (the Network did not answer) is left alone.

Nothing signed in is signed out: the old cookie (bench_at) is read as the session until the next sign-in
or refresh writes ov_token and clears it. The access token stays httpOnly; the navbar asks /auth/me.

The routes and the answers are the same: /auth/login (?next, ?silent, ?prompt, ?login_hint),
/auth/callback, /auth/logout (a same-site action: another site still cannot sign a person out),
/auth/me ({ user }), plus the SDK's /auth/health, /auth/fedcm and /auth/refresh.

The site's own sanitizeNext is kept (a same-site path, never another origin): the open-redirect
regression and the navbar's silent sign-in rely on it, and the SDK's own target check is stricter.
No Clear-Site-Data is sent on the callback or on sign-out: Chrome holds such an answer (and the cookies
it sets) until the cache is cleared (2026-10-28).

The same-origin write guard (http/same-origin.js) now recognises the SDK's cookie too:
both ov_token and the site's own bench_at are a cookie-authenticated write.

Changes

ddiff --git a/package-lock.json b/package-lock.json
iindex a4d8aae..ea577bf 100644
---- a/package-lock.json
++++ b/package-lock.json
@@@ -16,7 +16,7 @@
"helmet": "^8.1.0",
"iovalkey": "^0.4.0",
"openvibe-contracts": "https://codeload.github.com/OpenVibers/OpenVibe.Contracts/tar.gz/refs/tags/v0.238.0",
-- "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.70.0",
++ "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.73.0",
"openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.45.0",
"pg": "^8.23.0"
},
@@@ -1166,9 +1166,9 @@
}
},
"node_modules/openvibe-sdk": {
-- "version": "0.70.0",
-- "resolved": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.70.0",
-- "integrity": "sha512-iMNxlnRm0fmyj60nHiC/lKAaG3JAqiJgu42lShnkby4yF4dQJRG3G0trrqOoULZKBalrYHb/gjauRwNQYN/tog==",
++ "version": "0.73.0",
++ "resolved": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.73.0",
++ "integrity": "sha512-XClxoVm9M6RA8eXlGgYZ0u6q9n5h79mCXqAAEg9fX21KgcqP69RmG+cX+6wrOf7TaEj7eSBWMxHjiIeIa9N7Dg==",
"license": "MIT",
"bin": {
"openvibe-download": "bin/openvibe-download.js"
ddiff --git a/package.json b/package.json
iindex 1ab4eec..8b1394f 100644
---- a/package.json
++++ b/package.json
@@@ -23,7 +23,7 @@
"helmet": "^8.1.0",
"iovalkey": "^0.4.0",
"openvibe-contracts": "https://codeload.github.com/OpenVibers/OpenVibe.Contracts/tar.gz/refs/tags/v0.238.0",
-- "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.70.0",
++ "openvibe-sdk": "https://codeload.github.com/OpenVibers/OpenVibe.SDK/tar.gz/refs/tags/v0.73.0",
"openvibe-shared": "https://codeload.github.com/OpenVibers/OpenVibe.Shared/tar.gz/refs/tags/v4.45.0",
"pg": "^8.23.0"
},
ddiff --git a/server/app.js b/server/app.js
iindex 45a97b8..fc60659 100644
---- a/server/app.js
++++ b/server/app.js
@@@ -115,7 +115,7 @@ async function createApp(opts = {}) {
// ── Machine endpoints ───────────────────────────────────
app.get('/api/health', (_req, res) => res.json({ status: 'ok', service: 'openvibe-bench', name: 'OpenVibe.Bench', version: VERSION }));
release.mount(app, { registry: metrics.registry });
-- const readiness = createServiceReadiness({ s, config, release: release.release, valkey });
++ const readiness = createServiceReadiness({ s, config, release: release.release, valkey, sso });
app.get('/api/ready', readiness.handler);
// ── Who is signed in ────────────────────────────────────
ddiff --git a/server/auth/sso.js b/server/auth/sso.js
iindex 311fdd0..6a59de6 100644
---- a/server/auth/sso.js
++++ b/server/auth/sso.js
@@@ -1,23 +1,37 @@
'use strict';
/**
-- * Sign-in with OpenVibe.Network: OAuth 2 authorization code with PKCE (S256), as OAuth client `bench`.
++ * Sign-in with OpenVibe.Network: openvibe-sdk/sso (0.73.0) is the one module every site uses. This file is this
++ * site's thin wrapper around it — the routes, the middleware and the shapes this site's pages still read.
*
-- * GET /auth/login → Network /oauth/authorize
-- * GET /auth/callback → state check, server-side code exchange
-- * GET /auth/logout → clear cookies, revoke the refresh token (best effort)
-- * GET /auth/me → { user } for the shared navbar
++ * GET /auth/login → Network /oauth/authorize with state and PKCE (S256); ?next, ?silent, ?prompt, ?login_hint
++ * GET /auth/callback → the state is compared in constant time, the code is exchanged server-side (client secret)
++ * GET /auth/logout → the cookies are cleared, the refresh token revoked (best effort)
++ * GET /auth/me → { user } for the shared navbar
++ * GET /auth/health → { ok, client }: does the Network accept this site's OAuth client?
++ * POST /auth/fedcm → the shared navbar's FedCM assertion, swapped for tokens
++ * POST /auth/refresh → the tokens are rotated with the refresh token
*
-- * The person's Network access token lives in the httpOnly `bench_at` cookie; `bench_rt` is the refresh token and
-- * `bench_oauth` the short-lived PKCE flow. None are stored server-side, rendered or logged.
++ * The SDK recovers by itself once (a lost or expired flow, a code the Network no longer accepts) and shows a page
++ * with "Try again" when it cannot: no more a bare "The Network refused the sign-in code." A client the Network
++ * refuses is logged as a configuration error, and GET /auth/health answers 503 for it.
++ *
++ * Nothing signed in is signed out: the old cookie (bench_at) is read as the session until the next sign-in or
++ * refresh writes ov_token and clears it. The access token stays httpOnly: no script can read it (the navbar asks
++ * /auth/me).
*/
const crypto = require('crypto');
const express = require('express');
const cache = require('openvibe-shared/cache-policy');
++const { createSsoClient, COOKIES, parseCookies } = require('openvibe-sdk/sso');
const ACCESS_COOKIE = 'bench_at';
const REFRESH_COOKIE = 'bench_rt';
const HINT_COOKIE = 'ov_sso_hint';
++
++/** The cookie names a session is read from: the site's own before the move, the SDK's now. */
++const SESSION_COOKIES = [COOKIES.access, ACCESS_COOKIE];
++/** The flow cookie this site used to write (the SDK writes its own ov_oauth_* ones now): the name is kept exported. */
const FLOW_COOKIE = 'bench_oauth';
function pkcePair() {
@@@ -28,12 +42,13 @@ function pkcePair() {
function ownOrigins(config) {
const out = new Set();
-- for (const u of [config && config.baseUrl]) {
++ for (const u of [config && config.baseUrl, config && config.homes && config.homes.url]) {
try { if (u) out.add(new URL(u).origin); } catch { /* not a URL */ }
}
return out;
}
++/** Same-site relative paths only (never protocol-relative, never another origin). */
function sanitizeNext(next, config) {
if (typeof next === 'string' && /[\u0000-\u001f\u007f\\]/.test(next)) return '/';
if (typeof next === 'string' && /^https?:\/\//i.test(next)) {
@@@ -46,6 +61,7 @@ function sanitizeNext(next, config) {
return next;
}
++/** The authorize URL for a sign-in (pure; the SDK builds its own, this one stays for the site's tests). */
function authorizeUrl(config, { state, challenge, silent = false }) {
const q = new URLSearchParams({
response_type: 'code',
@@@ -61,53 +77,38 @@ function authorizeUrl(config, { state, challenge, silent = false }) {
}
function createSso({ config, keys, fetchImpl = globalThis.fetch, now = () => Date.now(), log = console }) {
-- const cookieBase = () => ({ sameSite: 'lax', secure: config.cookies.secure, httpOnly: true, path: '/' });
--
-- function setSession(res, data) {
-- res.cookie(ACCESS_COOKIE, data.access_token, { ...cookieBase(), maxAge: 24 * 60 * 60 * 1000 });
-- if (data.refresh_token) res.cookie(REFRESH_COOKIE, data.refresh_token, { ...cookieBase(), maxAge: 30 * 24 * 60 * 60 * 1000 });
-- res.cookie(HINT_COOKIE, 'account', { sameSite: 'lax', secure: config.cookies.secure, httpOnly: false, path: '/', maxAge: 365 * 24 * 60 * 60 * 1000 });
-- }
-- function clearSession(res) {
-- res.clearCookie(ACCESS_COOKIE, cookieBase());
-- res.clearCookie(REFRESH_COOKIE, cookieBase());
-- }
--
-- async function tokenGrant(fields) {
-- const body = new URLSearchParams({ client_id: config.oauth.clientId, client_secret: config.oauth.clientSecret, ...fields });
-- let res;
-- try {
-- res = await fetchImpl(`${config.networkInternalUrl}/oauth/token`, {
-- method: 'POST',
-- headers: { 'Content-Type': 'application/x-www-form-urlencoded', Accept: 'application/json' },
-- body, signal: AbortSignal.timeout(10_000),
-- });
-- } catch (err) {
-- throw Object.assign(new Error('OpenVibe.Network did not answer'), { status: 502, error: err && err.name === 'TimeoutError' ? 'timeout' : 'unreachable' });
-- }
-- const data = await res.json().catch(() => null);
-- if (!res.ok || !data || !data.access_token) {
-- throw Object.assign(new Error((data && (data.error_description || data.error)) || `token endpoint ${res.status}`),
-- { status: res.status, error: (data && data.error) || 'invalid_grant' });
-- }
-- return data;
-- }
++ // The one module. The site's own values, its own old cookies, and the audience it always verified with.
++ const sso = createSsoClient({
++ site: 'bench',
++ siteName: 'OpenVibe.Bench',
++ baseUrl: config.baseUrl,
++ clientId: config.oauth.clientId,
++ clientSecret: config.oauth.clientSecret,
++ networkUrl: config.networkUrl,
++ networkInternalUrl: config.networkInternalUrl || config.networkUrl,
++ issuer: config.networkIssuer || config.networkUrl,
++ redirectUri: config.oauth.redirectUri,
++ scope: config.oauth.scope,
++ audience: config.oauth.sessionAudience,
++ secureCookies: config.cookies.secure !== false,
++ httpOnlyAccess: true,
++ legacyCookies: { access: [ACCESS_COOKIE], refresh: [REFRESH_COOKIE] },
++ fetch: fetchImpl,
++ log,
++ });
-- async function verifySession(token) {
-- const v = await keys.verifyUser(token, { issuer: config.networkIssuer, audience: config.oauth.sessionAudience, now: now() });
-- const c = v.claims;
-- if (c && (c.typ === 'fedcm' || c.actor_type !== undefined)) return { ok: false, reason: 'not a session token' };
-- return v;
-- }
++ const cookieBase = () => ({ sameSite: 'lax', secure: config.cookies.secure !== false, httpOnly: true, path: '/' });
-- function viewerFromClaims(claims, token) {
++ /** The person, in the shape this site's pages read (req.viewer). */
++ function viewerFrom(claims, token) {
const subject = typeof claims.subject_id === 'string' ? claims.subject_id : null;
const role = typeof claims.role === 'string' ? claims.role : 'user';
++ const username = typeof claims.username === 'string' ? claims.username.slice(0, 64) : null;
return {
kind: 'user',
subject,
-- username: typeof claims.username === 'string' ? claims.username.slice(0, 64) : null,
-- displayName: typeof claims.display_name === 'string' ? claims.display_name.slice(0, 80) : (typeof claims.username === 'string' ? claims.username.slice(0, 64) : 'you'),
++ username,
++ displayName: typeof claims.display_name === 'string' ? claims.display_name.slice(0, 80) : (username || 'you'),
role,
avatarUrl: typeof claims.avatar_url === 'string' && /^https:\/\/[^\s"'<>]{1,500}$/.test(claims.avatar_url) ? claims.avatar_url : null,
profileColor: typeof claims.profile_color === 'string' && /^#[0-9a-fA-F]{3,8}$/.test(claims.profile_color) ? claims.profile_color : null,
@@@ -115,102 +116,97 @@ function createSso({ config, keys, fetchImpl = globalThis.fetch, now = () => Dat
};
}
-- async function refresh(req, res) {
-- if (!req.sessionRefresh) req.sessionRefresh = await doRefresh(req, res);
-- return req.sessionRefresh;
-- }
--
-- async function doRefresh(req, res) {
-- const rt = req.cookies && req.cookies[REFRESH_COOKIE];
++ /** The public profile the navbar and the API read (the same fields as before the move). */
++ const meOf = (claims) => {
++ const v = viewerFrom(claims, null);
++ return {
++ username: v.username,
++ display_name: v.displayName,
++ subject_id: v.subject,
++ role: v.role,
++ avatar_url: v.avatarUrl || null,
++ profile_color: v.profileColor || null,
++ };
++ };
++
++ /**
++ * The access token expired (or is gone) but the refresh token is still there: rotate it and write the SDK's own
++ * cookies, the same names and options the SDK uses. The old cookies are cleared.
++ */
++ async function refreshSession(req, res) {
++ const c = parseCookies(req);
++ const rt = c[COOKIES.refresh] || c[REFRESH_COOKIE];
if (!rt) return null;
-- try {
-- const data = await tokenGrant({ grant_type: 'refresh_token', refresh_token: rt });
-- setSession(res, data);
-- const v = await verifySession(data.access_token);
-- return v.ok ? viewerFromClaims(v.claims, data.access_token) : null;
-- } catch (err) {
-- if (err.status && err.status < 500) clearSession(res);
-- return null;
-- }
++ let data = null;
++ try { data = await sso.tokenGrant({ grant_type: 'refresh_token', refresh_token: rt }); } catch { return null; }
++ if (!data || !data.access_token) return null;
++ const claims = await sso.verify(data.access_token);
++ if (!claims) return null;
++ res.cookie(COOKIES.access, data.access_token, { ...cookieBase(), maxAge: 24 * 60 * 60 * 1000 });
++ if (data.refresh_token) res.cookie(COOKIES.refresh, data.refresh_token, { ...cookieBase(), path: '/auth', maxAge: 30 * 24 * 60 * 60 * 1000 });
++ res.clearCookie(ACCESS_COOKIE, { path: '/' });
++ res.clearCookie(REFRESH_COOKIE, { path: '/' });
++ return { claims, token: data.access_token };
}
++ /** req.user and req.token for a valid session; req.viewer keeps this site's pages working as they are. */
function middleware() {
-- return async (req, res, next) => {
++ const optional = sso.optionalAuth();
++ return (req, res, next) => {
req.viewer = { kind: 'anonymous' };
-- const header = String(req.get('authorization') || '');
-- const bearerToken = /^Bearer\s+\S/i.test(header) ? header.replace(/^Bearer\s+/i, '').trim() : null;
-- if (bearerToken) {
-- await keys.ensure();
-- const v = await verifySession(bearerToken);
-- if (v.ok) req.viewer = viewerFromClaims(v.claims, bearerToken);
++ optional(req, res, async () => {
++ try {
++ if (req.user && req.token) { req.viewer = viewerFrom(req.user, req.token); return next(); }
++ const fresh = await refreshSession(req, res);
++ if (fresh) {
++ req.user = fresh.claims;
++ req.token = fresh.token;
++ req.viewer = viewerFrom(fresh.claims, fresh.token);
++ }
++ } catch (err) {
++ log.warn('[OpenVibe.Bench] session refresh failed:', (err && err.message) || err);
++ }
return next();
-- }
-- const token = req.cookies && req.cookies[ACCESS_COOKIE];
-- if (!token) return next();
-- await keys.ensure();
-- const v = await verifySession(token);
-- if (v.ok) { req.viewer = viewerFromClaims(v.claims, token); return next(); }
-- if (v.expired) {
-- const fresh = await refresh(req, res);
-- if (fresh) { req.viewer = fresh; return next(); }
-- }
-- if (keys.loaded()) clearSession(res);
-- next();
++ });
};
}
++ /** A call with the person's own token; a 401 refreshes the session once and tries again. */
async function asViewer(req, res, fn) {
++ const token = req.token || (req.viewer && req.viewer.token) || null;
++ if (!token) throw Object.assign(new Error('Not signed in'), { status: 401 });
try {
-- return await fn(req.viewer.token);
++ return await fn(token);
} catch (err) {
if (!err || err.status !== 401) throw err;
-- const fresh = await refresh(req, res);
++ const fresh = await refreshSession(req, res);
if (!fresh) throw err;
-- req.viewer = fresh;
++ req.user = fresh.claims;
++ req.token = fresh.token;
++ req.viewer = viewerFrom(fresh.claims, fresh.token);
return fn(fresh.token);
}
}
function routes() {
const r = express.Router();
-- const flowOpts = () => ({ ...cookieBase(), path: '/auth', maxAge: 10 * 60 * 1000 });
-- r.get('/login', (req, res) => {
-- const silent = Boolean(req.query.silent) && req.query.silent !== '0';
-- const state = crypto.randomBytes(16).toString('hex');
-- const { verifier, challenge } = pkcePair();
-- res.cookie(FLOW_COOKIE, JSON.stringify({ state, verifier, next: sanitizeNext(req.query.next, config), silent }), flowOpts());
-- res.set('Cache-Control', cache.htmlHeaders({ private: true }));
-- res.redirect(authorizeUrl(config, { state, challenge, silent }));
-- });
++ // No Clear-Site-Data on the callback or on sign-out: this site never sent it, and Chrome holds such an answer
++ // (and the cookies it sets) until the cache is cleared.
-- r.get('/callback', async (req, res) => {
++ // GET /auth/me: the shared navbar's answer. A guest is { user: null } (200); a session that does not verify
++ // is 401, as it always was here.
++ r.get('/me', async (req, res) => {
res.set('Cache-Control', cache.htmlHeaders({ private: true }));
-- let flow = null;
-- try { flow = JSON.parse(req.cookies[FLOW_COOKIE] || 'null'); } catch { flow = null; }
-- res.clearCookie(FLOW_COOKIE, { ...cookieBase(), path: '/auth' });
-- const next = flow ? sanitizeNext(flow.next, config) : '/';
-- const { code, state, error } = req.query;
-- if (error) {
-- if ((flow && flow.silent) || error === 'login_required' || error === 'interaction_required') return res.redirect(next);
-- return res.status(400).type('text/plain').send(`Sign-in was not completed (${String(error).slice(0, 60)}).`);
-- }
-- if (!flow || typeof flow.state !== 'string' || typeof flow.verifier !== 'string' || typeof state !== 'string'
-- || state.length !== flow.state.length || !crypto.timingSafeEqual(Buffer.from(state), Buffer.from(flow.state))) {
-- return res.status(400).type('text/plain').send('Sign-in state did not match. Please try signing in again.');
-- }
-- if (!code) return res.status(400).type('text/plain').send('The Network sent no authorization code.');
-- try {
-- const data = await tokenGrant({ grant_type: 'authorization_code', code: String(code), redirect_uri: config.oauth.redirectUri, code_verifier: flow.verifier });
-- setSession(res, data);
-- return res.redirect(next);
-- } catch (err) {
-- log.warn('[OpenVibe.Bench] sign-in exchange failed:', err.status || '', err.error || '');
-- return res.status(err.status && err.status < 500 ? 400 : 502).type('text/plain')
-- .send(err.status && err.status < 500 ? 'The Network refused the sign-in code. Please sign in again.' : 'Sign-in failed: OpenVibe.Network did not answer. Please try again.');
-- }
++ const c = parseCookies(req);
++ const presented = Boolean(c[COOKIES.access] || c[ACCESS_COOKIE] || c[COOKIES.refresh] || c[REFRESH_COOKIE] || req.get('authorization'));
++ if (!presented) return res.json({ user: null });
++ const claims = await sso.verify(sso.extractToken(req));
++ if (!claims) return res.status(401).json({ error: 'Not signed in' });
++ return res.json({ user: meOf(claims) });
});
++ // Sign-out stays a same-site action: another site cannot sign a person out.
const sameOriginRequest = (req) => {
const site = String(req.get('sec-fetch-site') || '');
if (site) return site === 'same-origin' || (site === 'none' && req.method === 'GET');
@@@ -222,13 +218,14 @@ function createSso({ config, keys, fetchImpl = globalThis.fetch, now = () => Dat
if (sameOriginRequest(req)) return next();
res.set('Cache-Control', cache.htmlHeaders({ private: true }));
const q = req.query.next ? `?next=${encodeURIComponent(sanitizeNext(req.query.next, config))}` : '';
-- res.type('html').send(`<!doctype html><meta charset="utf-8"><title>Sign out</title><meta name="viewport" content="width=device-width,initial-scale=1">`
++ res.type('html').send('<!doctype html><meta charset="utf-8"><title>Sign out</title><meta name="viewport" content="width=device-width,initial-scale=1">'
+ `<form method="post" action="/auth/logout${q}" style="font:16px system-ui;margin:3em auto;max-width:24em;text-align:center">`
-- + `<p>Sign out of OpenVibe.Bench?</p><button type="submit">Sign out</button> <a href="/">Cancel</a></form>`);
++ + '<p>Sign out of OpenVibe.Bench?</p><button type="submit">Sign out</button> <a href="/">Cancel</a></form>');
});
r.post('/logout', (req, res, next) => (sameOriginRequest(req) ? next() : res.status(403).type('text/plain').send('Sign-out must come from this site.')));
r.all('/logout', async (req, res) => {
-- const rt = req.cookies && req.cookies[REFRESH_COOKIE];
++ const c = parseCookies(req);
++ const rt = c[COOKIES.refresh] || c[REFRESH_COOKIE];
if (rt) {
fetchImpl(`${config.networkInternalUrl}/oauth/revoke`, {
method: 'POST', headers: { 'Content-Type': 'application/json' },
@@@ -236,23 +233,20 @@ function createSso({ config, keys, fetchImpl = globalThis.fetch, now = () => Dat
signal: AbortSignal.timeout(3000),
}).catch(() => {});
}
-- clearSession(res);
-- res.cookie(HINT_COOKIE, 'guest', { sameSite: 'lax', secure: config.cookies.secure, httpOnly: false, path: '/', maxAge: 365 * 24 * 60 * 60 * 1000 });
-- res.redirect(303, sanitizeNext(req.query.next, config));
++ res.clearCookie(COOKIES.access, { path: '/' });
++ res.clearCookie(COOKIES.refresh, { path: '/auth' });
++ res.clearCookie(ACCESS_COOKIE, { path: '/' });
++ res.clearCookie(REFRESH_COOKIE, { path: '/' });
++ res.cookie(HINT_COOKIE, 'guest', { sameSite: 'lax', secure: config.cookies.secure !== false, httpOnly: false, path: '/', maxAge: 365 * 24 * 60 * 60 * 1000 });
++ return res.redirect(303, sanitizeNext(req.query.next, config));
});
-- r.get('/me', (req, res) => {
-- res.set('Cache-Control', cache.htmlHeaders({ private: true }));
-- const c = req.cookies || {};
-- if (!c[ACCESS_COOKIE] && !c[REFRESH_COOKIE] && !req.get('authorization')) return res.json({ user: null });
-- const v = req.viewer;
-- if (!v || v.kind !== 'user') return res.status(401).json({ error: 'Not signed in' });
-- res.json({ user: { username: v.username, display_name: v.displayName, subject_id: v.subject, role: v.role, avatar_url: v.avatarUrl || null, profile_color: v.profileColor || null } });
-- });
++ // The SDK's own routes: /login, /callback, /fedcm, /refresh, /health.
++ r.use(sso.router(express));
return r;
}
-- return { middleware, routes, asViewer, tokenGrant, pkcePair };
++ return { middleware, routes, asViewer, tokenGrant: (fields) => sso.tokenGrant(fields), pkcePair, client: sso, checkClient: (o) => sso.checkClient(o) };
}
--module.exports = { createSso, pkcePair, sanitizeNext, ownOrigins, authorizeUrl, ACCESS_COOKIE, REFRESH_COOKIE, FLOW_COOKIE };
++module.exports = { createSso, pkcePair, sanitizeNext, ownOrigins, authorizeUrl, ACCESS_COOKIE, REFRESH_COOKIE, FLOW_COOKIE, SESSION_COOKIES };
ddiff --git a/server/http/same-origin.js b/server/http/same-origin.js
iindex 99ec6fc..c62543c 100644
---- a/server/http/same-origin.js
++++ b/server/http/same-origin.js
@@@ -1,12 +1,15 @@
'use strict';
/**
-- * Same-origin writes (CSRF). A write authenticated by the httpOnly `bench_at` session cookie must come from this
-- * site: Sec-Fetch-Site: same-origin, or an Origin equal to BASE_URL's origin. A Bearer write is not
-- * cookie-authenticated and is unaffected.
++ * Same-origin writes (CSRF). A write authenticated by the httpOnly session cookie must come from this site:
++ * Sec-Fetch-Site: same-origin, or an Origin equal to BASE_URL's origin. A Bearer write is not cookie-authenticated
++ * and is unaffected.
++ *
++ * The session lives in `ov_token` since the move to openvibe-sdk/sso; the site's own `bench_at` cookie is still read
++ * as the session (until the next sign-in or refresh writes ov_token), so both are a cookie-authenticated write.
*/
const { http } = require('openvibe-contracts');
--const { ACCESS_COOKIE } = require('../auth/sso');
++const { SESSION_COOKIES } = require('../auth/sso');
function ownOrigin(config) {
try { return new URL(config.baseUrl).origin; } catch { return null; }
@@@ -18,7 +21,8 @@ function bearer(req) {
}
function cookieAuthenticated(req) {
-- return Boolean(req.cookies && req.cookies[ACCESS_COOKIE]);
++ const c = req.cookies || {};
++ return SESSION_COOKIES.some((name) => Boolean(c[name]));
}
function sameOrigin(req, config) {
ddiff --git a/server/observability.js b/server/observability.js
iindex 61070c4..0ea7477 100644
---- a/server/observability.js
++++ b/server/observability.js
@@@ -6,7 +6,7 @@
const { jwksStatus } = require('openvibe-sdk/auth');
const { createReadiness } = require('openvibe-shared/ready');
--function createServiceReadiness({ s, config, valkey = null, release = null }) {
++function createServiceReadiness({ s, config, valkey = null, release = null, sso = null }) {
return createReadiness({
service: 'bench',
release,
@@@ -30,6 +30,18 @@ function createServiceReadiness({ s, config, valkey = null, release = null }) {
},
},
{ name: 'oauth_client', required: false, check: () => (config.oauth.clientSecret ? true : 'OV_OAUTH_CLIENT_SECRET unset: sign-in cannot complete') },
++ {
++ // Does the Network accept this site's OAuth client? 'invalid' means the id or the secret is wrong:
++ // the service must not stay ready on a sign-in that cannot work. 'unknown' (the Network did not
++ // answer) is left alone — that is the Network's outage, not this site's configuration.
++ name: 'sso_client', required: true,
++ check: async () => {
++ if (!sso || typeof sso.checkClient !== 'function') return { skipped: 'no SSO client' };
++ const client = await sso.checkClient();
++ if (client === 'invalid') return 'the Network refuses this site\'s OAuth client: check OV_OAUTH_CLIENT_ID / OV_OAUTH_CLIENT_SECRET';
++ return true;
++ },
++ },
],
});
}
ddiff --git a/test/sso.test.js b/test/sso.test.js
nnew file mode 100644
iindex 0000000..44dd1bf
---- /dev/null
++++ b/test/sso.test.js
@@@ -0,0 +1,147 @@
++'use strict';
++/**
++ * Sign-in with PKCE S256 through openvibe-sdk/sso (0.73.0): the routes, the SDK's own recovery (a lost flow or a
++ * code the Network no longer accepts starts the sign-in once more by itself, and only then shows a page with
++ * "Try again"), the old cookies read as the session, the session-token rules (a FedCM assertion or an app token is
++ * not a session), the open-redirect guard, truthful readiness and cross-site sign-out.
++ */
++const assert = require('assert');
++const crypto = require('crypto');
++const { boot, check, done } = require('./helpers/boot');
++const { sanitizeNext } = require('../server/auth/sso');
++
++const cookieJar = (res) => res.headers.getSetCookie().map((c) => c.split(';')[0]).join('; ');
++
++(async () => {
++ const t = await boot();
++ const user = t.network.addUser('kim');
++
++ await check('login redirects to Network with state and an S256 code challenge', async () => {
++ const r = await t.get('/auth/login?next=/boards');
++ assert.strictEqual(r.status, 302);
++ const loc = new URL(r.headers.get('location'));
++ assert.strictEqual(loc.origin + loc.pathname, `${t.network.url}/oauth/authorize`);
++ assert.strictEqual(loc.searchParams.get('client_id'), 'bench');
++ assert.strictEqual(loc.searchParams.get('code_challenge_method'), 'S256');
++ assert.match(loc.searchParams.get('code_challenge'), /^[A-Za-z0-9_-]{43}$/);
++ assert.match(loc.searchParams.get('state'), /^[A-Za-z0-9_-]{32}$/);
++ assert.match(r.headers.get('set-cookie'), /ov_oauth_state=.*Path=\/auth.*HttpOnly/i);
++ });
++
++ await check('login passes ?silent, ?prompt and ?login_hint to the Network', async () => {
++ const silent = new URL((await t.get('/auth/login?silent=1')).headers.get('location'));
++ assert.strictEqual(silent.searchParams.get('prompt'), 'none');
++ const chooser = new URL((await t.get('/auth/login?prompt=select_account')).headers.get('location'));
++ assert.strictEqual(chooser.searchParams.get('prompt'), 'select_account');
++ const hint = new URL((await t.get('/auth/login?login_hint=kim')).headers.get('location'));
++ assert.strictEqual(hint.searchParams.get('login_hint'), 'kim');
++ });
++
++ await check('callback exchanges the code with the matching verifier and sets the SDK\'s own httpOnly cookies', async () => {
++ const login = await t.get('/auth/login?next=/boards');
++ const loc = new URL(login.headers.get('location'));
++ const flowCookie = cookieJar(login);
++ const code = t.network.issueCode(user, loc.searchParams.get('code_challenge'));
++ const r = await t.get(`/auth/callback?code=${code}&state=${loc.searchParams.get('state')}`, { cookie: flowCookie });
++ assert.strictEqual(r.status, 302, r.text);
++ assert.strictEqual(r.headers.get('location'), '/boards');
++ const set = r.headers.get('set-cookie');
++ assert.match(set, /ov_token=[^;]+;.*HttpOnly/i);
++ assert.match(set, /ov_refresh=[^;]+;.*HttpOnly/i);
++ assert.match(set, /bench_at=;/);
++ const at = set.match(/ov_token=([^;]+)/)[1];
++ const me = await t.get('/auth/me', { cookie: `ov_token=${at}` });
++ assert.strictEqual(me.json().user.username, 'kim');
++ assert.ok(!me.text.includes(at), '/auth/me never returns the token');
++ });
++
++ await check('the old cookie is still the session, so nobody is signed out by the move', async () => {
++ const at = t.network.userToken(user);
++ const me = await t.get('/auth/me', { cookie: `bench_at=${at}` });
++ assert.strictEqual(me.status, 200);
++ assert.strictEqual(me.json().user.username, 'kim');
++ assert.strictEqual(me.json().user.subject_id, user.subject);
++ });
++
++ await check('a wrong state, a verifier that does not match, or no flow cookie starts the sign-in once more', async () => {
++ const login = await t.get('/auth/login');
++ const loc = new URL(login.headers.get('location'));
++ const flowCookie = cookieJar(login);
++ const code = t.network.issueCode(user, loc.searchParams.get('code_challenge'));
++ const wrong = await t.get(`/auth/callback?code=${code}&state=${'0'.repeat(32)}`, { cookie: flowCookie });
++ assert.strictEqual(wrong.status, 302, 'the SDK recovers by itself once');
++ assert.match(wrong.headers.get('location'), /^\/auth\/login/);
++ const retry = cookieJar(wrong);
++ assert.match(retry, /ov_oauth_retry=1/);
++ const again = await t.get(`/auth/callback?code=${code}&state=${'0'.repeat(32)}`, { cookie: `${flowCookie}; ${retry}` });
++ assert.strictEqual(again.status, 400);
++ assert.match(again.text, /Try again/);
++ const other = t.network.issueCode(user, crypto.createHash('sha256').update('another-verifier').digest('base64url'));
++ assert.strictEqual((await t.get(`/auth/callback?code=${other}&state=${loc.searchParams.get('state')}`, { cookie: flowCookie })).status, 302);
++ assert.strictEqual((await t.get(`/auth/callback?code=${code}&state=${loc.searchParams.get('state')}`)).status, 302);
++ });
++
++ await check('next= only accepts same-site paths', async () => {
++ const r = await t.get('/auth/login?next=//evil.example/x');
++ assert.ok(!/ov_oauth_next=[^;]+/.test(String(r.headers.get('set-cookie') || '')), 'another origin is never a target');
++ const config = { baseUrl: 'https://bench.openvibe.services' };
++ assert.strictEqual(sanitizeNext('/boards?x=1', config), '/boards?x=1');
++ assert.strictEqual(sanitizeNext('https://bench.openvibe.services/boards?y=1', config), '/boards?y=1');
++ for (const v of ['//evil.com', '/\\evil.com', 'https://evil.com/x', '/\t/evil.com', 'javascript:alert(1)', 'https://bench.openvibe.services.evil.com/x']) assert.strictEqual(sanitizeNext(v, config), '/', v);
++ });
++
++ await check('/auth/health says whether the Network accepts this site\'s client', async () => {
++ const r = await t.get('/auth/health');
++ assert.strictEqual(r.status, 200);
++ assert.deepStrictEqual(r.json(), { ok: true, client: 'ok' });
++ });
++
++ await check('readiness is truthful: db required; JWKS, the OAuth client and Valkey optional', async () => {
++ const r = await t.get('/api/ready');
++ const b = r.json();
++ assert.strictEqual(r.status, 200);
++ assert.strictEqual(b.checks.db.status, 'ok');
++ assert.strictEqual(b.checks.db.required, true);
++ assert.strictEqual(b.checks.network_jwks.status, 'ok');
++ assert.strictEqual(b.checks.network_jwks.required, false);
++ assert.strictEqual(b.checks.oauth_client.status, 'ok');
++ assert.strictEqual(b.checks.oauth_client.required, false);
++ assert.strictEqual(b.checks.sso_client.status, 'ok');
++ assert.strictEqual(b.checks.sso_client.required, true);
++ assert.ok('valkey' in b.checks);
++ });
++
++ await check('/auth/me: a guest is signed out (200 { user: null }); a failing session cookie is 401', async () => {
++ const guest = await t.get('/auth/me');
++ assert.strictEqual(guest.status, 200);
++ assert.deepStrictEqual(JSON.parse(guest.text), { user: null });
++ assert.strictEqual(guest.headers.get('cache-control'), 'private, no-store');
++ assert.strictEqual((await t.get('/auth/me', { cookie: 'bench_at=garbage' })).status, 401);
++ assert.strictEqual((await t.get('/auth/me', { cookie: 'bench_rt=stale' })).status, 401);
++ assert.strictEqual((await t.get('/auth/me', { as: user })).status, 200);
++ });
++
++ await check('a FedCM assertion and an app token are not sessions', async () => {
++ const now = Math.floor(Date.now() / 1000);
++ const fedcm = t.network.signJwt({ iss: t.network.issuer(), sub: user.id, id: user.id, subject_id: user.subject, username: user.username, display_name: user.username, nonce: null, typ: 'fedcm', jti: 'x', aud: 'https://tenant.openvibe.host', iat: now, exp: now + 300 });
++ assert.strictEqual((await t.get('/auth/me', { cookie: `bench_at=${fedcm}` })).status, 401);
++ const app = t.network.signJwt({ iss: t.network.issuer(), sub: 'app:app_01JABCDEFGHJKMNPQRSTVWXYZ0', actor_type: 'app', aud: ['openvibe.network'], cap: ['x.y.z'], subject_id: user.subject, iat: now, exp: now + 300 });
++ assert.strictEqual((await t.get('/auth/me', { cookie: `bench_at=${app}` })).status, 401);
++ });
++
++ await check('another site cannot sign a person out; this site can', async () => {
++ const cross = await t.get('/auth/logout', { as: user, headers: { 'sec-fetch-site': 'cross-site' } });
++ assert.strictEqual(cross.status, 200);
++ assert.ok(!/bench_at=;|bench_at=deleted/i.test(String(cross.headers.get('set-cookie') || '')));
++ assert.match(cross.text, /method="post"/);
++ const crossPost = await t.get('/auth/logout', { as: user, method: 'POST', headers: { 'sec-fetch-site': 'cross-site' } });
++ assert.strictEqual(crossPost.status, 403);
++ const same = await t.get('/auth/logout?next=/boards', { as: user, headers: { 'sec-fetch-site': 'same-origin' } });
++ assert.strictEqual(same.status, 303);
++ assert.strictEqual(same.headers.get('location'), '/boards');
++ assert.match(String(same.headers.get('set-cookie') || ''), /bench_at=;/);
++ });
++
++ await t.close();
++ done();
++})();